Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audio.rs; publish to lib.rs #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekalosak
Copy link

@ekalosak ekalosak commented Jun 17, 2023

This compiles but is not tested; I'm putting this PR up early to get feedback ASAP from library maintainers.

Plan now is to:

  1. Make a CLI binding, user-like test
  2. Unit test

but I don't have a ton of time for this proj, I'm sorry to say - so perhaps someone else will get this over the line.

@AlbertMarashi
Copy link
Collaborator

The use of unwraps which might result in panics is not ideal so I think those should be propagated in the result errors.

Can you write some tests to validate the code as well?

@AlbertMarashi AlbertMarashi added enhancement New feature or request good first issue Good for newcomers labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants