Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support get a product's release' all tasks from Product Pages #12

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Support get a product's release' all tasks from Product Pages #12

merged 2 commits into from
Jul 12, 2024

Conversation

zhanglu1122
Copy link
Contributor

@zhanglu1122 zhanglu1122 commented Jun 11, 2024 •
edited
Loading

  1. Created an client to connect to PP for release api
  2. Updated README on some command and links
  3. Rename customize logging class, otherwise it confused with internal logging class
  4. Adding Tests

JIRA: RHELWF-10975

@zhanglu1122 zhanglu1122 requested a review from a team as a code owner June 11, 2024 09:40
@zhanglu1122 zhanglu1122 marked this pull request as draft June 11, 2024 09:41
hluk
hluk reviewed Jun 11, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
hluk
hluk reviewed Jun 11, 2024
View reviewed changes
src/retasc/constants.py Outdated Show resolved Hide resolved
hluk
hluk reviewed Jun 11, 2024
View reviewed changes
src/retasc/constants.py Outdated Show resolved Hide resolved
@zhanglu1122 zhanglu1122 marked this pull request as ready for review June 18, 2024 05:59
@zhanglu1122 zhanglu1122 force-pushed the RHELWF-10975 branch 4 times, most recently from 80e31cc to 0784cc0 Compare June 18, 2024 06:47
hluk
hluk reviewed Jun 18, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@zhanglu1122 zhanglu1122 force-pushed the RHELWF-10975 branch 4 times, most recently from 4d6ad36 to 6869da8 Compare June 19, 2024 03:15
@zhanglu1122
Copy link
Contributor Author

@hluk all tests passed, PTAL, thx

hluk
hluk reviewed Jun 19, 2024
View reviewed changes
Containerfile Outdated Show resolved Hide resolved
src/retasc/constants.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Show resolved Hide resolved
src/retasc/product_pages_api.py Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
tests/test_product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
@zhanglu1122 zhanglu1122 force-pushed the RHELWF-10975 branch 3 times, most recently from 3bb4800 to 650a23d Compare June 21, 2024 06:13
hluk
hluk requested changes Jun 21, 2024
View reviewed changes
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/constants.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
tests/test_product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
@zhanglu1122 zhanglu1122 force-pushed the RHELWF-10975 branch 5 times, most recently from 833bf12 to 0a31e69 Compare June 24, 2024 08:03
hluk
hluk requested changes Jun 24, 2024
View reviewed changes
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/retasc/requests_session.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
tests/test_product_pages_api.py Outdated Show resolved Hide resolved
@zhanglu1122 zhanglu1122 requested a review from hluk June 28, 2024 09:00
hluk
hluk requested changes Jun 28, 2024
View reviewed changes
.github/workflows/gating.yaml Outdated Show resolved Hide resolved
Containerfile Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
tests/test_product_pages_api.py Show resolved Hide resolved
tests/test_product_pages_api.py Outdated Show resolved Hide resolved
tests/test_requests_session.py Outdated Show resolved Hide resolved
@zhanglu1122 zhanglu1122 force-pushed the RHELWF-10975 branch 2 times, most recently from c78327a to 388b56f Compare July 1, 2024 08:53
hluk
hluk reviewed Jul 1, 2024
View reviewed changes
Containerfile Outdated Show resolved Hide resolved
@zhanglu1122 zhanglu1122 requested a review from hluk July 9, 2024 05:35
@zhanglu1122 zhanglu1122 requested a review from hluk July 9, 2024 10:37
@zhanglu1122
Copy link
Contributor Author

@hluk PTAL, I have made the suggested changes. Thanks

hluk
hluk reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@hluk hluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comment, otherwise LGTM! 👍

src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
src/retasc/product_pages_api.py Outdated Show resolved Hide resolved
@dependabot
Support get a product's release' all tasks from Product Pages
bf5cdea 
Created an client to connect to PP for release api
Updated README on some command and links
Updated Docker and CI files with krb5 install to avoid ci failure
Rename customize logging class, otherwise it confused with internal logging class
Adding Tests to test coverage 100%

JIRA: RHELWF-10975
@zhanglu1122 zhanglu1122 requested a review from hluk July 11, 2024 05:41
hluk
hluk approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@hluk hluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhanglu1122 zhanglu1122 merged commit 1bceff5 into main Jul 12, 2024
14 checks passed
@zhanglu1122 zhanglu1122 deleted the RHELWF-10975 branch July 12, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hluk hluk hluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhanglu1122 @hluk