Clean up binary representations and merkle trees #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eagle941
reviewed
Jan 28, 2024
Eagle941
reviewed
Jan 28, 2024
Eagle941
reviewed
Jan 28, 2024
Eagle941
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This significantly unifies and clears our theorems for binary reps and merkle trees. Removes custom binary types in lieu of plain
Bools, to avoid conversion hell. Also removes a lot of weirdly stated theorems. Also tries to unify naming to follow mathlib's convention, but this is only done opportunistically and deserves another pass.Details
Checklist