Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86_64 #26

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Fix x86_64 #26

merged 4 commits into from
Aug 15, 2024

Conversation

jamcleod
Copy link
Member

  • Add bzImage building (and enable for x86_64)
  • Fix clobbering issue in hypercall implementation
  • Add other various config options

Copy link

@AndrewFasano AndrewFasano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small questions, but this looks good.

@@ -1,3 +1,21 @@
#include "x86-common.inc"

CONFIG_SMP=y
CONFIG_COMPAT=y
CONFIG_SERIAL_NONSTANDARD=y

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why nonstandard?

Comment on lines +8 to +13
CONFIG_SERIAL_8250_NR_UARTS=32
CONFIG_SERIAL_8250_EXTENDED=y
CONFIG_SERIAL_8250_MANY_PORTS=y
CONFIG_SERIAL_8250_SHARE_IRQ=y
CONFIG_SERIAL_8250_DETECT_IRQ=y
CONFIG_SERIAL_8250_RSA=y

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are unnecessary, could we delete? If they're required that's fine.

Comment on lines +20 to +21
CONFIG_PCI_QUIRKS=y
CONFIG_BLK_DEV_SD=y

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same point for these being necessary or not.

@AndrewFasano AndrewFasano merged commit 1920825 into main Aug 15, 2024
7 checks passed
@AndrewFasano AndrewFasano deleted the x86_64-bzImage branch August 15, 2024 19:26
@jamcleod
Copy link
Member Author

Table of combinations of options I've tried for serial:

With SERIAL_8250 options Without
With SERIAL_NONSTANDARD
Without

SERIAL_NONSTANDARD is definitely necessary. Some combination of the 8250 options are also necessary.

CONFIG_PCI_QUIRKS and CONFIG_BLK_DEV_SD do not seem necessary to boot so can possibly be removed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants