-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix x86_64 #26
Fix x86_64 #26
Conversation
jamcleod
commented
Aug 14, 2024
- Add bzImage building (and enable for x86_64)
- Fix clobbering issue in hypercall implementation
- Add other various config options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small questions, but this looks good.
@@ -1,3 +1,21 @@ | |||
#include "x86-common.inc" | |||
|
|||
CONFIG_SMP=y | |||
CONFIG_COMPAT=y | |||
CONFIG_SERIAL_NONSTANDARD=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why nonstandard?
CONFIG_SERIAL_8250_NR_UARTS=32 | ||
CONFIG_SERIAL_8250_EXTENDED=y | ||
CONFIG_SERIAL_8250_MANY_PORTS=y | ||
CONFIG_SERIAL_8250_SHARE_IRQ=y | ||
CONFIG_SERIAL_8250_DETECT_IRQ=y | ||
CONFIG_SERIAL_8250_RSA=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are unnecessary, could we delete? If they're required that's fine.
CONFIG_PCI_QUIRKS=y | ||
CONFIG_BLK_DEV_SD=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same point for these being necessary or not.
Table of combinations of options I've tried for serial:
|