Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job control in console for Panda and Penguin #2

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

ddermendzhiev
Copy link

This PR does two things, fixing Job Control in two scenarios.

  1. Scenario: you run Panda with two serial devices, exposing the second over telnet. Problem: Job Control was not working because the curproc was the session (process group) leader, thus not allowing setsid() to create a new session (setsid() man page). Solution: fork() before calling setsid()
  2. Scenario: you run Penguin and connect to the shell exposed over telnet. Problem: Ctrl+C was not working as expected. The character gets rendered in the output, but no SIGINT is raised. Solution: explicitly re-raise the proper signal with its default handler (SIG_DFL)

@ddermendzhiev ddermendzhiev self-assigned this Jul 1, 2024
@AndrewFasano AndrewFasano merged commit b989674 into master Jul 1, 2024
1 check passed
@AndrewFasano AndrewFasano deleted the fix-job-control branch July 1, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants