-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie move tests #1199
Cookie move tests #1199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied over everything from the old src/regolith/tests/conftest.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignoring test_helpers.py (flake8: lines too long) and test_commands.py so I can skip conftest import
@tinatn29 Hi Tina, could you try to re-run CI here now using |
@tinatn29 if you can make a push to this PR it should retrigger the CI. Bob showed above how to make an emtpy commit to do that. Or if there is any edit to make, you can do that too. |
just did! The tests are running now... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cookie #1199 +/- ##
=========================================
Coverage ? 79.64%
=========================================
Files ? 17
Lines ? 1366
Branches ? 0
=========================================
Hits ? 1088
Misses ? 278
Partials ? 0
|
Fix #1178
mv
and notgit mv
. I triedgit mv
but it didn't work with some pycache complaints...)flake8
in.pre-commit-config.yaml
exclude tests/test_helpers.py and tests/test_commands.pyResults:
pre-commit run --all-files
now passes