Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie move tests #1199

Merged
merged 17 commits into from
Nov 28, 2024
Merged

Cookie move tests #1199

merged 17 commits into from
Nov 28, 2024

Conversation

tinatn29
Copy link
Contributor

@tinatn29 tinatn29 commented Nov 22, 2024

Fix #1178

  • move tests from src/regolith/tests to ./tests (sorry I used mv and not git mv. I tried git mv but it didn't work with some pycache complaints...)
  • make flake8 in .pre-commit-config.yaml exclude tests/test_helpers.py and tests/test_commands.py
  • fix minor typos (codespell)

Results:

  • pytest is passing locally (with 34 skipped and 57 warnings, same as before the move)
  • pre-commit run --all-files now passes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied over everything from the old src/regolith/tests/conftest.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoring test_helpers.py (flake8: lines too long) and test_commands.py so I can skip conftest import

@bobleesj
Copy link

bobleesj commented Nov 27, 2024

@tinatn29 Hi Tina,

could you try to re-run CI here now using git commit --allow-empty -m "Re-cun CI with empty commit"? Hopefully it passes now.

@sbillinge
Copy link
Contributor

@tinatn29 if you can make a push to this PR it should retrigger the CI. Bob showed above how to make an emtpy commit to do that. Or if there is any edit to make, you can do that too.

@tinatn29
Copy link
Contributor Author

tinatn29 commented Nov 27, 2024

just did! The tests are running now...

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 61.71875% with 98 lines in your changes missing coverage. Please review.

Please upload report for BASE (cookie@ab909d3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tests/conftest.py 61.71% 98 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             cookie    #1199   +/-   ##
=========================================
  Coverage          ?   79.64%           
=========================================
  Files             ?       17           
  Lines             ?     1366           
  Branches          ?        0           
=========================================
  Hits              ?     1088           
  Misses            ?      278           
  Partials          ?        0           
Files with missing lines Coverage Δ
tests/test_broker.py 100.00% <ø> (ø)
tests/test_builders.py 84.28% <ø> (ø)
tests/test_chain_db.py 100.00% <ø> (ø)
tests/test_client_manager.py 47.61% <ø> (ø)
tests/test_commands.py 29.26% <ø> (ø)
tests/test_dates.py 100.00% <ø> (ø)
tests/test_fsclient.py 100.00% <ø> (ø)
tests/test_helpers.py 62.80% <ø> (ø)
tests/test_main.py 100.00% <ø> (ø)
tests/test_runcontrol.py 100.00% <ø> (ø)
... and 6 more

@sbillinge sbillinge merged commit 87febe5 into regro:cookie Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants