Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#4 #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue#4 #7

wants to merge 2 commits into from

Conversation

ptitdoc
Copy link

@ptitdoc ptitdoc commented Apr 6, 2016

Attempts to fix Issue#4 (successfull) for the python native library.

There is however still missing fixes:

  • Help the user to pass some of the c library parameters properly (by using asserts?)
  • Fix the clibnet code that still segfault at callback registration time

Olivier Medoc added 2 commits April 5, 2016 16:23
…e class to avoid pointer dereferencement because of potential garbage collection
@@ -90,9 +95,13 @@ def query(self, command, argument):

May raise a RuntimeError.
"""
ret = nfct_query(self.handle, command, argument)
if ret != 0:
self.query_type = command
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting looks weird here ? That should confuse Python.

@regit
Copy link
Owner

regit commented Apr 6, 2016

Thanks a lot @ptitdoc, could you reformat the commit message following http://chris.beams.io/posts/git-commit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants