Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Ensure LSF bjobs gets the right format #2968

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

fenoyc
Copy link
Contributor

@fenoyc fenoyc commented Aug 4, 2023

On sites with non-default bjobs output format, ReFrame fails to detect the state of the job

On sites with non-default bjobs output format, ReFrame fails to detect the state of the job
@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@vkarak vkarak requested review from vkarak and victorusu August 7, 2023 08:22
@vkarak vkarak changed the title Ensure bjobs gets the right format [bugfix] Ensure bjobs gets the right format Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eda6b23) 87.36% compared to head (6c18139) 87.36%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2968   +/-   ##
========================================
  Coverage    87.36%   87.36%           
========================================
  Files           60       60           
  Lines        11687    11687           
========================================
  Hits         10210    10210           
  Misses        1477     1477           
Files Changed Coverage Δ
reframe/core/schedulers/lsf.py 49.36% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teojgo teojgo self-requested a review August 7, 2023 13:30
@teojgo
Copy link
Contributor

teojgo commented Aug 7, 2023

Ok to test

@vkarak
Copy link
Contributor

vkarak commented Aug 22, 2023

@fenoyc Would that still work for systems using the default output format?

@vkarak vkarak changed the title [bugfix] Ensure bjobs gets the right format [bugfix] Ensure LSF bjobs gets the right format Aug 25, 2023
@vkarak vkarak added this to the ReFrame 4.4 milestone Aug 25, 2023
@vkarak vkarak merged commit e2f59b6 into reframe-hpc:develop Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants