Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.2: first class PixiJS v8 support #10

Merged
merged 9 commits into from
Apr 27, 2024
Merged

v1.2.2: first class PixiJS v8 support #10

merged 9 commits into from
Apr 27, 2024

Conversation

reececomo
Copy link
Owner

Improves PixiV8 support by updating library type-hinting (and naming conventions) to Container from DisplayObject.

What's changed?

  • improves PixiV8 support by updating types to reflect common between v6, v7 and v8
  • Replace references to PIXI.DisplayObject in types with PIXI.Container
  • renamed Action.runOnChildWithName(action, name) to Action.runOnChild(nameOrLabel, action)
    • flipped argument order to be more expressive (sorry SKAction.runOnChild(_: withName:) 💔)
    • added under-the-hood support for v8's getChildByLabel() when available to minimize deprecation warnings and rename
    • changed error reporting behavior to report a TypeError when target can'wt have children, or ReferenceError when no child was found
    • no functional changes
  • Added PIXI 6.1, 7.2 and 8.1 to test matrix to validate changes

@reececomo reececomo changed the title v1.2.2: improve PixiJS v8+ support v1.2.2: first class PixiJS v8+ support Apr 27, 2024
@reececomo reececomo changed the title v1.2.2: first class PixiJS v8+ support v1.2.2: first class PixiJS v8 support Apr 27, 2024
@reececomo reececomo merged commit 8d51869 into main Apr 27, 2024
7 checks passed
@reececomo reececomo deleted the v1.2.2-fix-v8 branch April 27, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant