-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intermission.md including a caution block to let the reader know not to look for a Typescript version #8885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow not to look for a Typescript version. I'm a first-time Redwood user. While working through the tutorial, once I hit the intermission and started working through the examples, I realized cloning the tutorial repo with the default instructions contained js-only code. Since the tutorial provided example snippets in Typescript, I figured there must be a separate branch or way to download a typescript version. After poking around, I found this open issue redwoodjs/redwood-tutorial#56 and realized this was in progress, so this just edits the documentation to save other readers time while working through the tutorial. I'm no copywriter, and the tutorial seems to take a specific tone, so please feel free to edit the copy or make suggestions (i.e. link to the github issue in the comment so people can track it) I didn't include the issue since there doesn't seem to be a precedent for doing so in the rest of the documentation. Using Redwood for the first time has been a great experience by the way!
jtoar
changed the title
Update intermission.md including a caution block to let the reader kn…
Update intermission.md including a caution block to let the reader know not to look for a Typescript version.
Jul 12, 2023
jtoar
changed the title
Update intermission.md including a caution block to let the reader know not to look for a Typescript version.
Update intermission.md including a caution block to let the reader know not to look for a Typescript version
Jul 12, 2023
jtoar
suggested changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jgal1, made a few small edits, let me know what you think.
Co-authored-by: Dominic Saadi <[email protected]>
Thanks @jtoar , yeah I risked it and didn't actually test the markdown rendering sorry about that and thanks for fixing! |
jtoar
approved these changes
Jul 12, 2023
jtoar
added a commit
that referenced
this pull request
Jul 17, 2023
…ow not to look for a Typescript version (#8885) I'm a first-time Redwood user. While working through the tutorial, once I hit the intermission and started working through the examples, I realized cloning the tutorial repo with the default instructions contained js-only code. Since the tutorial provided example snippets in Typescript, I figured there must be a separate branch or way to download a typescript version. After poking around, I found this open issue redwoodjs/redwood-tutorial#56 and realized this was in progress, so this just edits the documentation to save other readers time while working through the tutorial. I'm no copywriter, and the tutorial seems to take a specific tone, so please feel free to edit the copy or make suggestions (i.e. link to the github issue in the comment so people can track it) I didn't include the issue since there doesn't seem to be a precedent for doing so in the rest of the documentation. Using Redwood for the first time has been a great experience by the way! --------- Co-authored-by: Dominic Saadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a first-time Redwood user. While working through the tutorial, once I hit the intermission and started working through the examples, I realized cloning the tutorial repo with the default instructions contained js-only code. Since the tutorial provided example snippets in Typescript, I figured there must be a separate branch or way to download a typescript version. After poking around, I found this open issue redwoodjs/redwood-tutorial#56 and realized this was in progress, so this just edits the documentation to save other readers time while working through the tutorial. I'm no copywriter, and the tutorial seems to take a specific tone, so please feel free to edit the copy or make suggestions (i.e. link to the github issue in the comment so people can track it) I didn't include the issue since there doesn't seem to be a precedent for doing so in the rest of the documentation. Using Redwood for the first time has been a great experience by the way!