Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: network resource requires cloud_provider and region #170

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: network resource requires cloud_provider and region #170

merged 1 commit into from
Oct 21, 2024

Conversation

ligfx
Copy link
Contributor

@ligfx ligfx commented Oct 15, 2024

No description provided.

@ligfx ligfx added the ci-ready label Oct 15, 2024
@ligfx ligfx force-pushed the network_region_cloud_provider_required branch from a7af693 to afac49c Compare October 15, 2024 14:49
gene-redpanda
gene-redpanda approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ligfx ligfx merged commit 52d79a7 into redpanda-data:main Oct 21, 2024
10 checks passed
@ligfx ligfx deleted the network_region_cloud_provider_required branch November 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@r-vasquez r-vasquez Awaiting requested review from r-vasquez r-vasquez is a code owner

Assignees
No one assigned
Labels
ci-ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ligfx @gene-redpanda