Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TestingOnlyStringSliceToTypeList -> StringSliceToTypeList #166

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ligfx
Copy link
Contributor

@ligfx ligfx commented Oct 8, 2024

Avoid error checking all over the place when it can be done safely.

Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love it on principle but you're right that it can be done relatively safely.

Avoid error checking all over the place when it can be done safely.
@ligfx ligfx force-pushed the StringSliceToTypeList branch from 4bdb8db to d4c413e Compare October 21, 2024 18:34
@ligfx
Copy link
Contributor Author

ligfx commented Oct 21, 2024

I don't love it on principle but you're right that it can be done relatively safely.

Yeah, weird that Terraform doesn't provide this. I've seen this helper function repeated again and again in a lot of provider codebases.

@ligfx ligfx merged commit f9d2e63 into redpanda-data:main Oct 21, 2024
10 checks passed
@ligfx ligfx deleted the StringSliceToTypeList branch November 8, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants