Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add BZMPOP #1191

Merged
merged 1 commit into from
May 29, 2023
Merged

✨ Add BZMPOP #1191

merged 1 commit into from
May 29, 2023

Conversation

JerrodCarpenter
Copy link
Contributor

@JerrodCarpenter JerrodCarpenter commented May 22, 2023

  redis-rb git:(master)  ./bin/console   
irb(main):001:0> redis = Redis.new(url: "redis://localhost:6379/2")
=> #<Redis client v5.0.6 for redis://localhost:6379/2>
irb(main):002:0> redis.zadd("myzset", [[1, "one"], [2, "two"], [3, "three"]])
=> 3
irb(main):003:0> redis.bzmpop(1.0, "myzset", modifier: "MAX", count: 3)
=> ["myzset", [["three", 3.0], ["two", 2.0], ["one", 1.0]]]
irb(main):004:0> redis.bzmpop(1.0, "myzset", modifier: "MAX", count: 3)
=> nil

@JerrodCarpenter
Copy link
Contributor Author

I'm checking out the failed test, it seems unrelated to the changes though?

@byroot
Copy link
Collaborator

byroot commented May 29, 2023

it seems unrelated to the changes though?

Yes, unfortunately the cluster tests tend to be a bit flaky.

@byroot byroot merged commit 1f4041a into redis:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants