Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cache restore to include python version #479

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update cache restore to include python version #479

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cfeeced
chore(ci): run tests with correct python version
YaraslauZhylko Feb 13, 2023
77fc2db
another approach
YaraslauZhylko Feb 13, 2023
fcc75cf
another try
YaraslauZhylko Feb 13, 2023
2030be7
yet another try
YaraslauZhylko Feb 13, 2023
278c24b
Merge branch 'main' into chore/run-tests-with-correct-python
YaraslauZhylko Feb 13, 2023
9e4ff1d
use matrix.pyver
YaraslauZhylko Mar 1, 2023
038dcb0
limit mypy platform
YaraslauZhylko Mar 2, 2023
2610d3f
Merge branch 'main' into chore/run-tests-with-correct-python
chayim Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
uses: actions/cache@v3
with:
path: .venv
key: venv-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }}
key: venv-${{ runner.os }}-${{ hashFiles('**/pyproject.toml') }}
- name: Make sync version of library (redis_om)
run: make sync
#----------------------------------------------
Expand Down Expand Up @@ -126,6 +126,7 @@ jobs:
uses: actions/checkout@v3
- name: Setup Python ${{ matrix.pyver }}
uses: actions/setup-python@v4
id: setup-python
with:
python-version: ${{ matrix.pyver }}
#----------------------------------------------
Expand All @@ -145,7 +146,7 @@ jobs:
uses: actions/cache@v3
with:
path: .venv
key: venv-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }}
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/pyproject.toml') }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Using ${{ steps.setup-python.outputs.python-version }} because ${{ matrix.pyver }} resolves to nothing. 🤷‍♂️
  2. Using the hash of the pyproject.toml because poetry.lock got removed in Add poetry.lock to .gitignore #457.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ matrix.pyver }} perhaps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... 🤔

Last time I tried 2 weeks ago, ${{ matrix.pyver }} did not work (resolved to nothing). That's why I mentioned it in the comments.

But today it worked. 🤷‍♂️

Maybe GitHub Action got update, or maybe I mistyped something...

So I fixed the code to use matrix.pyver.

#----------------------------------------------
# Make sync version of library (redis_om)
#----------------------------------------------
Expand Down