Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SslOptions with custom HostnameVerifier #4032

Closed
wants to merge 38 commits into from
Closed

Add SslOptions with custom HostnameVerifier #4032

wants to merge 38 commits into from

Commits on Sep 29, 2024

  1. Add SslOptions from Lettuce library

    @sazzad16
    sazzad16 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    23ef9c3 View commit details
    Browse the repository at this point in the history

  2. Add InsecureTrustManagerFactory from Netty library

    @sazzad16
    sazzad16 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    375e1ca View commit details
    Browse the repository at this point in the history

  3. Separate SSL socket creation in DefaultJedisSocketFactory

    @sazzad16
    sazzad16 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    ed26f37 View commit details
    Browse the repository at this point in the history

  4. Add SslOptions in JedisClientConfig

    @sazzad16
    sazzad16 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    382fd81 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Add SslHostnameVerifyMode 

    inspired by SslVerifyMode in Lettuce
    @sazzad16
    sazzad16 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    363d493 View commit details
    Browse the repository at this point in the history

  2. Allow system default key and trust managers and insecure trust manager

    @sazzad16
    sazzad16 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    261bf30 View commit details
    Browse the repository at this point in the history

  3. fix jdoc

    @sazzad16
    sazzad16 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2ca615e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Address review comments

    @sazzad16
    sazzad16 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8da45c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Revert back to verification mode names in Lettuce, 

    to avoid confusion at this moment.
    @sazzad16
    sazzad16 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e9444d9 View commit details
    Browse the repository at this point in the history

  2. Rename insecureTrust to noTruststoreVerification; 

    does this reduce confusion?
    @sazzad16
    sazzad16 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ae97c00 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ssl-options

    @sazzad16
    sazzad16 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    04fd034 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. SslVerifyMode is renamed back 

    and INSECURE option (renamed from NONE) is added back in SslVerifyMode.
    @sazzad16
    sazzad16 committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    09fee5e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ssl-options

    @sazzad16
    sazzad16 committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    ea3a164 View commit details
    Browse the repository at this point in the history

  3. Remove InsecureTrustManagerFactory

    @sazzad16
    sazzad16 committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    499dfed View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Disable ALL existing SSL tests

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b196739 View commit details
    Browse the repository at this point in the history

  2. JedisTest with SslOptions

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1566a2a View commit details
    Browse the repository at this point in the history

  3. SSLACLJedisTest with SslOptions

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    06e2587 View commit details
    Browse the repository at this point in the history

  4. SSLOptionsJedisSentinelPoolTest with SslOptions

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4b27241 View commit details
    Browse the repository at this point in the history

  5. SSLJedisClusterTest with SslOptions

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    caa0b34 View commit details
    Browse the repository at this point in the history

  6. TODO comment to enable existing SSL tests

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    11bb446 View commit details
    Browse the repository at this point in the history

  7. TODO command to enable existing SSL tests in csc package

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ff88451 View commit details
    Browse the repository at this point in the history

  8. Enable existing SSL tests without impacting new ones

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    315d73d View commit details
    Browse the repository at this point in the history

  9. Missing enable existing SSL tests without impacting new ones

    @sazzad16
    sazzad16 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    00d6dce View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. Keep only Builder pattern constructor for DefaultJedisClientConfig

    @sazzad16
    sazzad16 committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    f56aec3 View commit details
    Browse the repository at this point in the history

  2. Limit HostnameVerifier only for legacy ssl config 

    and document as JavaDoc in JedisClientConfig
    @sazzad16
    sazzad16 committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    06371b5 View commit details
    Browse the repository at this point in the history

  3. Remove unused codes from SSLOptionsJedisTest

    @sazzad16
    sazzad16 committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    bcce93b View commit details
    Browse the repository at this point in the history

  4. Increase code reuse for LocalhostVerifier

    @sazzad16
    sazzad16 committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    1fa23f2 View commit details
    Browse the repository at this point in the history

  5. Individual JavaDoc for each SslVerifyMode

    @sazzad16
    sazzad16 committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    a64a510 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Custom SocketFactory won't be supported with SslOptions

    @sazzad16
    sazzad16 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    63aa76b View commit details
    Browse the repository at this point in the history

  2. Deprecate DefaultJedisClientConfig.copyConfig()

    @sazzad16
    sazzad16 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    10bc2dc View commit details
    Browse the repository at this point in the history

  3. Add option to set SSLContext protocol

    @sazzad16
    sazzad16 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a0591c8 View commit details
    Browse the repository at this point in the history

  4. Remove options to set KeyManager and TrustManager algorithms

    @sazzad16
    sazzad16 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    309d477 View commit details
    Browse the repository at this point in the history

  5. Add File checkers

    @sazzad16
    sazzad16 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    42596bd View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. minor user/password change

    @sazzad16
    sazzad16 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1a44be1 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. minor update javadoc

    @sazzad16
    sazzad16 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    46c031e View commit details
    Browse the repository at this point in the history

  2. Allow manual HostnameVerifier with SslOptions

    @sazzad16
    sazzad16 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    294cf25 View commit details
    Browse the repository at this point in the history

  3. Make test connectWithCustomHostNameVerifier() pass

    @sazzad16
    sazzad16 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ac1de9c View commit details
    Browse the repository at this point in the history

  4. Better SslOptions with custom HostnameVerifier 

    in connectWithCustomHostNameVerifier() test
    @sazzad16
    sazzad16 committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    9e60a8e View commit details
    Browse the repository at this point in the history