Extend CLIENT SETINFO support #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #3509 +/- ##
============================================
+ Coverage 71.21% 71.22% +0.01%
- Complexity 4763 4769 +6
============================================
Files 277 277
Lines 14999 15024 +25
Branches 1057 1060 +3
============================================
+ Hits 10681 10701 +20
- Misses 3853 3858 +5
Partials 465 465
☔ View full report in Codecov by Sentry. |
vladvildanov
requested changes
Aug 22, 2023
This was
linked to
issues
Aug 22, 2023
sazzad16
commented
Sep 4, 2023
uglide
requested changes
Sep 6, 2023
| return false; | ||
| } | ||
|
|
||
| default String libNameSuffix() { |
There was a problem hiding this comment.
Please document here the requirements for the libNameSuffix:
" " < c && c != "(" && c != ")" && c < "~"
|
@uglide @yangbodong22011 ping |
yangbodong22011
approved these changes
Sep 13, 2023
sazzad16
added a commit
that referenced
this pull request
Sep 14, 2023
* Extend CLIENT SETINFO support * Modify JedisMetaInfo * Fix custom lib name and ver * Remove version suffix * Separate ClientSetInfoConfig * Address braces * Rename method to isDisabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.