Skip to content

Commit

Permalink
Mark SSL & ACL test's since 7.0
Browse files Browse the repository at this point in the history
In 6.2.16 CLUSTER slots command returns the non-tls port when contacted by tls one.
Tests need to be revisited to make them compatible with 6.2.x
  • Loading branch information
ggivo committed Nov 19, 2024
1 parent 28287ea commit 5cfdb42
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import redis.clients.jedis.exceptions.JedisClusterOperationException;

@SinceRedisVersion("6.0.0")
@SinceRedisVersion(value = "7.0.0", message = "Redis 6.2.x returns non-tls port in CLUSTER SLOTS command. Enable for 6.2.x after tests are fixed.")
public class SSLACLJedisClusterTest extends JedisClusterTestBase {

private static final int DEFAULT_REDIRECTIONS = 5;
Expand Down Expand Up @@ -54,7 +54,6 @@ public static void prepare() {
}

@Test
@SinceRedisVersion(value = "7.0.0", message = "Redis 6.2.x returns non-tls port in CLUSTER SLOTS command. Enable for 6.2.x after test is fixed.")
public void testSSLDiscoverNodesAutomatically() {
DefaultJedisClientConfig config = DefaultJedisClientConfig.builder()
.user("default")
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/redis/clients/jedis/SSLJedisClusterTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import redis.clients.jedis.exceptions.JedisClusterOperationException;

@SinceRedisVersion(value = "7.0.0", message = "Redis 6.2.x returns non-tls port in CLUSTER SLOTS command. Enable for 6.2.x after test is fixed.")
public class SSLJedisClusterTest extends JedisClusterTestBase {

private static final int DEFAULT_REDIRECTIONS = 5;
Expand Down Expand Up @@ -47,7 +48,6 @@ public static void prepare() {
}

@Test
@SinceRedisVersion(value = "7.0.0", message = "Redis 6.2.x returns non-tls port in CLUSTER SLOTS command. Enable for 6.2.x after test is fixed.")
public void testSSLDiscoverNodesAutomatically() {
try (JedisCluster jc = new JedisCluster(Collections.singleton(new HostAndPort("localhost", 8379)),
DefaultJedisClientConfig.builder().password("cluster")
Expand Down Expand Up @@ -115,7 +115,6 @@ public void testSSLWithoutPortMap() {
}

@Test
@SinceRedisVersion(value = "7.0.0", message = "Redis 6.2.x returns non-tls port in CLUSTER SLOTS command. Enable for 6.2.x after test is fixed.")
public void connectByIpAddress() {
try (JedisCluster jc = new JedisCluster(new HostAndPort("127.0.0.1", 8379),
DefaultJedisClientConfig.builder()
Expand Down

0 comments on commit 5cfdb42

Please sign in to comment.