fix: hide sensitive data from debug logs #1797
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1796
With my limited knowledge of this code base, I have tried to patch the specific scenario reported in #1796.
I think there can be improvements to this code but I lack the code base knowledge to put this logic in an universal place where all logs will sanitize values associated with the command
auth
.How I tested using
[email protected]
docker pull redis/redis-stack-server:latest
docker run -d --name redis-stack-server -p 6379:6379 redis/redis-stack-server:latest
npm install ioredis
node_modules/ioredis/built/utils/debug.js
directly with this PR codeDEBUG=ioredis:* node app.js
with the file below.ioredis:redis write command[127.0.0.1:6379]: 0 -> auth('***********') +1ms