Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate creation of Redis Cloud API spec #973

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Automate creation of Redis Cloud API spec #973

merged 1 commit into from
Dec 17, 2024

Conversation

paoloredis
Copy link
Collaborator

No description provided.

Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

As an enhancement, I wonder if it's possible to add the redis/docs group as a reviewer on the PR (so that the team is notified when the PR is opened). Seems like it's possible, but needs a personal access token: https://stackoverflow.com/questions/64976278/request-pr-review-from-team-via-cli

@paoloredis
Copy link
Collaborator Author

It would not be a good idea to use a PAT.

@cmilesb cmilesb merged commit a7a57c2 into main Dec 17, 2024
4 checks passed
@cmilesb cmilesb deleted the DOC-4621 branch December 17, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants