Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP: add search v2.8.13 rel. notes #213

Merged
merged 2 commits into from
May 14, 2024
Merged

OP: add search v2.8.13 rel. notes #213

merged 2 commits into from
May 14, 2024

Conversation

@dwdougherty dwdougherty requested a review from a team May 14, 2024 14:06
@dwdougherty dwdougherty self-assigned this May 14, 2024
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments but I guess release notes are deliberately terse anyway, so maybe not a problem.

- [#4534](https://github.com/RediSearch/RediSearch/pull/4534) FT.PROFILE with incorrect arguments could cause a crash on cluster setup (MOD-6791)
- [#4530](https://github.com/RediSearch/RediSearch/pull/4530) Some parameter settings using just prefixes instead of full values were working (MOD-6709)
- [#4539](https://github.com/RediSearch/RediSearch/pull/4539) Unfree memory while re-indexing loading a new RDB could cause a crash (MOD-6831, 6810)
- [#4498](https://github.com/RediSearch/RediSearch/pull/4498) Vector pre-filtered query (hybrid query) that timeout causing a crash due to deadlock when trying to write a new document (MOD-6510, MOD-6244)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "that" or say "times out"?

- [#4513](https://github.com/RediSearch/RediSearch/pull/4513) FT.CURSOR READ in a numeric query causing a crash (MOD-6597)
- [#4534](https://github.com/RediSearch/RediSearch/pull/4534) FT.PROFILE with incorrect arguments could cause a crash on cluster setup (MOD-6791)
- [#4530](https://github.com/RediSearch/RediSearch/pull/4530) Some parameter settings using just prefixes instead of full values were working (MOD-6709)
- [#4539](https://github.com/RediSearch/RediSearch/pull/4539) Unfree memory while re-indexing loading a new RDB could cause a crash (MOD-6831, 6810)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having "re-indexing" and "loading" next to each other takes a bit of parsing to understand - "when loading" or "during loading" maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy. I'm pretty sure folks would just cut and paste from GitHub, but I guess it doesn't hurt to do a bit of copy-editing here and there.

Copy link
Collaborator Author

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andy's changes.

- [#4513](https://github.com/RediSearch/RediSearch/pull/4513) FT.CURSOR READ in a numeric query causing a crash (MOD-6597)
- [#4534](https://github.com/RediSearch/RediSearch/pull/4534) FT.PROFILE with incorrect arguments could cause a crash on cluster setup (MOD-6791)
- [#4530](https://github.com/RediSearch/RediSearch/pull/4530) Some parameter settings using just prefixes instead of full values were working (MOD-6709)
- [#4539](https://github.com/RediSearch/RediSearch/pull/4539) Unfree memory while re-indexing loading a new RDB could cause a crash (MOD-6831, 6810)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy. I'm pretty sure folks would just cut and paste from GitHub, but I guess it doesn't hurt to do a bit of copy-editing here and there.

@dwdougherty dwdougherty merged commit f7fac74 into main May 14, 2024
4 checks passed
@dwdougherty dwdougherty deleted the DOC-3795 branch May 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RediSearch 2.8 release notes - there is no mention about 2.8.13
2 participants