Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s: expand PVC #165

Merged
merged 9 commits into from
May 8, 2024
Merged

K8s: expand PVC #165

merged 9 commits into from
May 8, 2024

Conversation

kaitlynmichael
Copy link
Contributor

@kaitlynmichael kaitlynmichael self-assigned this May 2, 2024
@kaitlynmichael kaitlynmichael requested a review from alon-zada May 2, 2024 16:41
@kaitlynmichael kaitlynmichael requested a review from a team May 6, 2024 20:41
dwdougherty
dwdougherty requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. I just reviewed language, as I'm not qualified to judge the technical content.

content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
@kaitlynmichael kaitlynmichael requested a review from dwdougherty May 6, 2024 20:50
dwdougherty
dwdougherty approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mich-elle-luna
mich-elle-luna requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo I think?

content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
mich-elle-luna
mich-elle-luna requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! I think this needs some work, let me know if you need help with it.

content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
mich-elle-luna
mich-elle-luna approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you , just one small typo 'is must'

content/operate/kubernetes/re-clusters/expand-pvc.md Outdated Show resolved Hide resolved
@kaitlynmichael kaitlynmichael merged commit bdad59f into main May 8, 2024
3 checks passed
@kaitlynmichael kaitlynmichael deleted the DOC-3664 branch May 8, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@mich-elle-luna mich-elle-luna mich-elle-luna approved these changes

@almoggue almoggue almoggue approved these changes

@bascar bascar Awaiting requested review from bascar

@laurentdroin laurentdroin Awaiting requested review from laurentdroin

@yuvallevy2 yuvallevy2 Awaiting requested review from yuvallevy2

@alon-zada alon-zada Awaiting requested review from alon-zada

Assignees

@kaitlynmichael kaitlynmichael

Labels
k8s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaitlynmichael @dwdougherty @almoggue @mich-elle-luna