Spelling and linting

SCAutolib/__init__.py

@@ -111,7 +111,7 @@ def run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=True,
     """
     if return_code is None:
         return_code = [0]
-    if type(cmd) == str:
+    if isinstance(cmd, str):
         cmd = cmd.split(" ")
     logger.debug(f"run: {' '.join([str(i) for i in cmd])}")
     out = subprocess.run(cmd, stdout=stdout, stderr=stderr, encoding="utf-8",

SCAutolib/controller.py

@@ -133,7 +133,7 @@ def setup_system(self, install_missing: bool, gdm: bool, graphical: bool):
 
         if graphical:
             run(['dnf', 'groupinstall', 'Server with GUI', '-y'])
-            # disable subsription message
+            # disable subscription message
             run(['systemctl', '--global', 'mask',
                  'org.gnome.SettingsDaemon.Subscription.target'])
             # disable welcome message

SCAutolib/models/card.py

@@ -63,7 +63,7 @@ def load(json_file, **kwars):
 
         card = None
         if cnt["type"] == "virtual":
-            assert "user" in kwars.keys(),\
+            assert "user" in kwars.keys(), \
                 "No user is provided to load the card."
             card = VirtualCard(user=kwars["user"],
                                softhsm2_conf=Path(cnt["softhsm"]))

SCAutolib/utils.py

@@ -149,7 +149,7 @@ def user_factory(username, **kwargs):
     user = None
     if user_file.exists():
         result = BaseUser.load(user_file, **kwargs)
-    if type(result) == tuple:
+    if isinstance(result, tuple):
         user, card_file = result
         logger.debug(f"Loading card from {card_file}")
         user.card = Card.load(card_file, user=user)

test/test_file.py

@@ -19,7 +19,7 @@ def test_create_fail(file_test_prepare):
     file_test = file_test_prepare
     with file_test._conf_file.open('w') as config:
         config.write('Test config file')
-    with pytest.raises(FileExistsError, match=f'{file_test._conf_file } '
+    with pytest.raises(FileExistsError, match=f'{file_test._conf_file} '
                                               f'already exists'):
         file_test.create()