plugin_scheduler: Adjust error logging in _set_affinity #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tuned/plugins/plugin_scheduler.py
Outdated
| except (AttributeError, KeyError) as e: | ||
| log.error("Failed to get task info for PID %d: %s" | ||
| % (pid, e)) | ||
| return -2 | ||
| finally: | ||
| return False |
Check warning
Code scanning / CodeQL
'break' or 'return' statement in finally Warning
There was a problem hiding this comment.
The CodeQL is probably right here, this could hide other unhandled exceptions happening inside the try: block.
There was a problem hiding this comment.
It seems the CodeQL didn't trigger the rescan.
There was a problem hiding this comment.
It's no more issue with the recent force push.
zacikpa
force-pushed
the
defunct-affinity
branch
3 times, most recently
from
8a2c4d1 to
c55f4f5
Compare
Do not report an error if a process is defunct even if it is not bound to specific CPUs: failing to change its affinity does not have any negative effects. Refactor the helper function _affinity_changeable to _ignore_set_affinity_error and make it return True/False depending on whether the failed affinity change can be ignored (i.e., not reported as an error). Do not check for vanished processes twice, the later check is sufficient. Resolves: RHEL-46560
zacikpa
force-pushed
the
defunct-affinity
branch
from
c55f4f5 to
30908c3
Compare
|
/packit build |
yarda
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to change the affinity of a defunct process should not cause any issues, even if the process is not bound to specific CPUs. We should thus not log this failure as an error. This PR introduces a change that causes TuneD to log such failures as debug messages only, along with some refactoring/simplification of the relevant functions.
Resolves: RHEL-46560