Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand variables in plugin_irq #658

Merged

Conversation

adriaan42
Copy link
Contributor

Forgot to expand variables in the new irq plugin.

Side question: is there a reason that variables in options are not automatically expanded, e.g. right after loading the profile? They are automatically expanded for @command invocations, but not for the "general" non-command tuning.

@yarda
Copy link
Contributor

yarda commented Jul 24, 2024

/packit build

@yarda
Copy link
Contributor

yarda commented Jul 24, 2024

Thanks, LGTM.

Side question: is there a reason that variables in options are not automatically expanded, e.g. right after loading the profile? They are automatically expanded for @command invocations, but not for the "general" non-command tuning.

I think it's because during the expansion various functions can be called which could have side effects. E.g. the ${f:exec:} can alter the system state. Thus the variables are expanded and the functions executed only when needed and in the order the @commands are called.

But it could be improved.

@yarda
Copy link
Contributor

yarda commented Jul 24, 2024

CentOS 7 CI failure is unrelated and being worked on by the TFT team.

@yarda yarda merged commit e547fef into redhat-performance:master Jul 24, 2024
13 of 14 checks passed
@adriaan42 adriaan42 deleted the adriaan/fix-irq-variable-expand branch July 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants