-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: dump: added new command #625
base: master
Are you sure you want to change the base?
Conversation
It's work in progress PoC. I will probably change the API method to use structured output instead of the flat string, also documentation will be updated accordingly. @jmencak please test and provide feedback. |
I will probably add the |
I like the idea.
Yeah, I've noticed. I wonder if support for this planned or at least variable definitions will be shown? They are not at the moment of testing. Is there a Jira card for this so that I could read about the rationale apart from what I read above (useful for debugging)? Thank you! |
This is a good idea, I will add list of variables. It shouldn't be hard. For actual values, it would require extra storage (currently the values aren't stored anywhere and always re-calculated) and refactor of the current code. It's doable, but it depends whether such feature is needed.
I think there is no Jira card at the moment, but we could create one. I was told by @MarSik few days ago that such feature is urgently needed. |
Not sure what Martin had in mind, I haven't synced with him about this, but I like the idea of being able to inspect the current configuration. |
I will also add the |
The dump command dumps active profile. It's good for debugging, because the output is flattened, i.e. it shows the resulting profile after inheritance (profiles merging) is processed. It keeps naming conventions - for tuned-adm it's named 'dump' action, for API it's named 'dump_profile' method. The 'priority' value is not output, but output is ordered according to it. The 'cpuinfo_regex' and 'uname_regex' are not output, but output is rendered according to it. Variables are not expanded. Signed-off-by: Jaroslav Škarvada <[email protected]>
The dump command dumps active profile. It's good for debugging, because the output is flattened, i.e. it shows the resulting profile after inheritance (profiles merging) is processed.
It keeps naming conventions - for tuned-adm it's named 'dump' action, for API it's named 'dump_profile' method.
The 'priority' value is not output, but output is ordered according to it.
The 'cpuinfo_regex' and 'uname_regex' are not output, but output is rendered according to it.
Variables are not expanded.