Add package to {cpus,uncores} matching functions #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarda
reviewed
May 23, 2024
yarda
reviewed
May 23, 2024
yarda
reviewed
May 23, 2024
yarda
reviewed
May 23, 2024
|
Is it ready for merge, or still WIP (because it has WIP flag)? From my point of view it's ready. I added few comments that could improve it, but I can see no problem with this PR. |
sgruszka
force-pushed
the
uncore_matching
branch
from
ce66e10 to
620d960
Compare
Addressed the comments and remove WIP flag. Please review. |
|
/packit build |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yarda
reviewed
Jul 22, 2024
|
CI failure seems unrelated to this PR. |
Allow to specify CPUs and uncores using package (socket) number.
type=cpu
devices=${f:package2cpus:2} # cpus from package 2
type=cpu
devices=${f:package2cpus:1*} # cpus from any package started from 1 i.e. 11, 12, 13 ...
type=uncore
devices=${f:package2uncores:1:5:9} # uncores from package 1, 5 and 9
Signed-off-by: Stanislaw Gruszka <[email protected]>
sgruszka
force-pushed
the
uncore_matching
branch
from
620d960 to
9312ac2
Compare
|
Addressed the comments, please review. |
|
/packit build |
yarda
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to specify cpus and uncores based on package (socket) number.