Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cluster_read.py): Disable InsecureRequestWarning properly #103

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix(cluster_read.py): Disable InsecureRequestWarning properly #103

merged 1 commit into from
Dec 21, 2023

Conversation

pablomh
Copy link
Contributor

@pablomh pablomh commented Dec 21, 2023

Using requests >= 2.16.0 this is the proper way to disable that warning.

/<HIDDEN>/venv/lib64/python3.11/site-packages/urllib3/connectionpool.py:1100: InsecureRequestWarning: Unverified HTTPS request is being made to host '<HIDDEN>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings
  warnings.warn(

@pablomh
fix(cluster_read.py): Disable InsecureRequestWarning properly
97ca964 
Using `requests >= 2.16.0` this is the proper way to disable that warning
@pablomh pablomh requested a review from jhutar December 21, 2023 13:10
jhutar
jhutar approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pablomh pablomh merged commit 4a13310 into main Dec 21, 2023
6 checks passed
@pablomh pablomh deleted the pablomh-patch-1 branch December 21, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhutar jhutar jhutar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablomh @jhutar