Update the email msg #886
Merged
Update the email msg #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
reviewed
Dec 31, 2024
| {% elif record[col] == 'database_idle' %} | ||
| <td>{{ record[col] }} - {{ record['CreateDate'].split(" ")[0] }}</td> | ||
| {% elif record[col] == 'instance_idle' %} | ||
| <td>{{ record[col] }} - {{ record['LaunchTime'].split("T")[0] }}</td> |
There was a problem hiding this comment.
what about other policies ?
unattached_ip
unattached_volume
s3_inactive
empty_roles
zombie_snapshots
zombie_nat_gateways
There was a problem hiding this comment.
No, these policies are running in dry_run=no. As these are instances we added the start date.
| @@ -66,6 +66,16 @@ | |||
| {% else %} | |||
| {% if col == 'PublicCloud' %} | |||
| <td>{{ record[col] or 'AWS' }}</td> | |||
| {% elif col == 'policy' %} | |||
| {% if record[col] == 'ec2_stop' %} | |||
There was a problem hiding this comment.
is it the right policy name 'ec2_stop', I thought we change it to 'stop_instance' ?
There was a problem hiding this comment.
earlier we decided not to change.
There was a problem hiding this comment.
What the effort to change it, I think it can be relevant for azure ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Added the stopped_date, create_date of ec2_stop, instance_idle, database_idle policies.
ref:
For security reasons, all pull requests need to be approved first before running any automated CI