Added the cro reports to es #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
added
documentation
ebattat
reviewed
Oct 10, 2023
...overnance/cloud_resource_orchestration/clouds/azure/resource_groups/azure_monitor_tickets.py
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,66 @@ | |||
|
|
|||
There was a problem hiding this comment.
Can we have the same abstract class interface for Azure and AWS ?
There was a problem hiding this comment.
yes, same interface class used
| def __init__(self, region_name: str = ''): | ||
| super().__init__() | ||
|
|
||
| # Todo All the below methods will be implement in future releases |
There was a problem hiding this comment.
This is the Todo statement
...rnance/cloud_resource_orchestration/clouds/azure/resource_groups/azure_tagging_operations.py
Outdated
Show resolved
Hide resolved
| from cloud_governance.main.environment_variables import environment_variables | ||
|
|
||
|
|
||
| class CollectCROReports(AbstractCollectCROReports): |
There was a problem hiding this comment.
Same question, why we need separate CRO class for Azure ?
There was a problem hiding this comment.
yes, the interface is same
cloud_governance/cloud_resource_orchestration/common/run_cro.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/common/run_cro.py
Outdated
Show resolved
Hide resolved
cloud_governance/cloud_resource_orchestration/common/run_cro.py
Outdated
Show resolved
Hide resolved
athiruma
force-pushed
the
cro_azure_upload_to_es
branch
from
f5499cc to
d446cfc
Compare
ebattat
reviewed
Oct 12, 2023
cloud_governance/cloud_resource_orchestration/clouds/common/abstract_collect_cro_reports.py
Outdated
Show resolved
Hide resolved
...rnance/cloud_resource_orchestration/clouds/azure/resource_groups/azure_tagging_operations.py
Outdated
Show resolved
Hide resolved
..._governance/cloud_resource_orchestration/clouds/azure/resource_groups/collect_cro_reports.py
Outdated
Show resolved
Hide resolved
athiruma
force-pushed
the
cro_azure_upload_to_es
branch
from
d446cfc to
5b3ac06
Compare
Yeah sure. |
|
@athiruma, are we ok with the nested common folder ? |
I am ok with this. Will be renamed it according to the requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
For security reasons, all pull requests need to be approved first before running any automated CI