Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Argo CD resource #42

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

natifridman
Copy link
Contributor

Update Argo CD base.

  • Remove .spec.resourceCustomizations as deprecated
  • Update Argo CD to v1beta1

Fix #41

Update Argo CD base.
- Remove `.spec.resourceCustomizations` as deprecated
- Update Argo CD to `v1beta1`
@novacain1
Copy link
Member

Thanks for this PR Nati. Will this change make it so clusters with OpenShift GitOps version 1.9 continue to function? 1.9 is the product supported version of the GitOps Operator at the present time for 4.13 and for 4.14.

@natifridman
Copy link
Contributor Author

Thanks for this PR Nati. Will this change make it so clusters with OpenShift GitOps version 1.9 continue to function? 1.9 is the product supported version of the GitOps Operator at the present time for 4.13 and for 4.14.

This is for clusters with OpenShift GitOps 1.10 to continue to function, you can see the error in our cluster because of this deprecation.
This should work in 1.9 as well

Copy link
Member

@novacain1 novacain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@novacain1 novacain1 merged commit 4cb6e60 into redhat-partner-solutions:main Oct 9, 2023
2 checks passed
@natifridman natifridman deleted the update-argocd branch October 9, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD v1alpha1 version is deprecated
2 participants