populate_mirror_registry | Ensure pullsecret is placed in config_file_path #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nocturnalastro
approved these changes
Oct 23, 2023
nocturnalastro
merged commit 9010a3e
into
redhat-partner-solutions:main
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pullsecret is copied in
config_file_pathinsetup_mirror_registry, and this copy can be modified in that role. This role is usually executed prior topopulate_mirror_registry, so we need to check if the pullsecret is present there or not.We have cases using DCI where we don't execute the
setup_mirror_registryrole, but we runpopulate_mirror_registry/prerequisitesto download binaries. For this case, where it may happen that the pullsecret is not placed inconfig_file_path, we have to ensure that.