OPCT-299: fix check/SLO for Kubernetes conformance and CLI refs #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix SLO by looking at the correct filter name.
mtulio
changed the title
mtulio
added
kind/bug
|
/lgtm |
|
Thanks @rvanderp3 ! Looks like openshift-ci bot is pretty busy today. I am going merging the PR manually to incorporate |
mtulio
merged commit c71b5e5
into
redhat-openshift-ecosystem:main
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
OPCT-001 (Kubernetes Conformance [10-openshift-kube-conformance] must pass 100%")is reportingpassingeven if there are failures in the pipeline.The reason is in v0.5.0 the filters have been duplicated, and the check evaluation keeps looking into an empty list (not populated in the new pipeline flow), generating a false positive/pass.