Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCT-257: CI fix release/publish pipeline on GHA #114

Merged

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Aug 6, 2024

This PR review the Github Actions (GHA) pipeline when publishing/releasing a new image when push to tags and main branch.

Additionally, it merges the linters and e2e to a dedicated workflow definition file.

It will also use the same workflow file to the entire pipeline, preventing managing many configurations for different events.

Dry-run of this version is available in the following link:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2024
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mtulio. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio marked this pull request as ready for review August 6, 2024 22:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2024
@openshift-ci openshift-ci bot requested review from faermanj and rvanderp3 August 6, 2024 22:40
@mtulio mtulio force-pushed the fix-ci-pipeline-release branch from e29c565 to b5484d6 Compare August 7, 2024 03:28
@mtulio mtulio added kind/bug Categorizes issue or PR as related to a bug. component/CI labels Aug 7, 2024
@mtulio
Copy link
Contributor Author

mtulio commented Aug 7, 2024

Manifest bumping plugins for v0.5.0-alpha.5 is passing, and PR merged #104

This PR must be passing now the yaml linter.

@mtulio mtulio changed the title OPCT-257/ci: fix release/publish pipeline on GHA OPCT-257: CI fix release/publish pipeline on GHA Aug 7, 2024
@mtulio
Copy link
Contributor Author

mtulio commented Aug 7, 2024

Green signal. Moving on this PR to unblock v0.5 pipeline.

@mtulio mtulio merged commit e0e2687 into redhat-openshift-ecosystem:main Aug 7, 2024
10 of 11 checks passed
@mtulio mtulio deleted the fix-ci-pipeline-release branch August 7, 2024 13:41
@mtulio mtulio restored the fix-ci-pipeline-release branch August 8, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/CI kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant