Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPCT-292: cmd/publish - add experimental publish used in CI #109

Closed
wants to merge 1 commit into from
Closed

OPCT-292: cmd/publish - add experimental publish used in CI #109

wants to merge 1 commit into from

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jul 26, 2024

Add a experimental command to allow Prow CI to publish results in the
opct-storage (S3) without needing to install dependencies in the test
step, preventing failures.

Incorporated in v0.5 branch to create alpha.4 release to fix on Prow CI:

[1] https://github.com/openshift/release/blob/950c61795a69898149ab7678efee771b4c002ae6/ci-operator/step-registry/provider-certification-tool/results/provider-certification-tool-results-commands.sh#L43-L55

@mtulio mtulio added kind/feature Categorizes issue or PR as related to a new feature. component/CLI labels Jul 26, 2024
@openshift-ci openshift-ci bot requested review from faermanj and jcpowermac July 26, 2024 18:35
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mtulio. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio force-pushed the backport-cmd-exp-publish branch from 2c71537 to 0bf575c Compare July 26, 2024 19:29
@mtulio
Copy link
Contributor Author

mtulio commented Jul 26, 2024

This is the use case on ProwCI: https://github.com/openshift/release/pull/54718/files#diff-14cb4a0859d2829d184ecdd72e4f90f7a17107eaecdd6187b11110b46bd92f56R66-R73

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2024
@mtulio
OPCT-292: cmd/publish - add experimental publish used in CI
1fa5eb3 
Add a experimental command to allow Prow CI to publish results in the
opct-storage (S3) without needing to install dependencies in the test
step, preventing failures.

OPCT-292: cmd/publish - add metadata option when publishing artifact
@mtulio mtulio force-pushed the backport-cmd-exp-publish branch from 0bf575c to 1fa5eb3 Compare July 28, 2024 22:20
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2024
@mtulio
Copy link
Contributor Author

mtulio commented Aug 2, 2024

/assign @rvanderp3

@mtulio mtulio marked this pull request as draft August 6, 2024 04:58
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2024
@mtulio
Copy link
Contributor Author

mtulio commented Aug 6, 2024

Converting to draft and holding it, probably it wont go. In #76 a more powerful command opct adm baseline (list|get|reindex|publish) is added to be used in the Prow CI jobs, report filter pipeline, and users while exploring the results.

@mtulio
Copy link
Contributor Author

mtulio commented Aug 6, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio
Copy link
Contributor Author

mtulio commented Aug 9, 2024

Aborting this approach since opct adm baseline publish replaces it with more restrictive mode.

@mtulio mtulio closed this Aug 9, 2024
@mtulio mtulio deleted the backport-cmd-exp-publish branch August 9, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faermanj faermanj Awaiting requested review from faermanj

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

Assignees

@rvanderp3 rvanderp3

Labels
component/CLI do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. state/experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtulio @openshift-merge-robot @rvanderp3