Knative Service icon could contain a Knative logo.

[sudhirverma]

Fix: #196

[codecov-commenter]

Codecov Report

Merging #200 (e8a824d) into main (c152971) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   92.99%   92.79%   -0.21%     
==========================================
  Files          74       74              
  Lines        2942     2942              
  Branches      468      468              
==========================================
- Hits         2736     2730       -6     
- Misses        206      212       +6     

Impacted Files	Coverage Δ
src/eventingTree/eventingTreeItem.ts	100.00% <ø> (ø)
.../functions/function-tree-view/functionsTreeItem.ts	34.61% <ø> (ø)
src/util/platform.ts	88.23% <0.00%> (-11.77%)	⬇️
src/cli/cmdCli.ts	49.27% <0.00%> (-4.35%)	⬇️
src/util/watch.ts	93.33% <0.00%> (-3.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c152971...e8a824d. Read the comment docs.

[lstocchi]

Adding a comment on the issue, wait a sec before merging it please

[lstocchi]

Not sure if this can be made but it would be better if icons could be a bit bigger.
I have glasses so maybe this is my problem 😆 but i really don't see any difference if i sit normally in front of my screen. I need to get closer to read what's inside the labels.

Then maybe you can think about adding icons to the categories as well, as we do with tekton. Now there are folder icons. But this is your or Mohit choice

[mohitsuman]

@sudhirverma Can you paste the latest icon size and how it looks ?

[sudhirverma]

@lstocchi updated size

Should I change Brokers folder icon to labels B

[mohitsuman]

@sudhirverma We need to do the following changes:

• RSVC & REV badge size needs to be increased, with margin/padding
• C in Channels and Sources have different font sizes. Make it consistent.
• Text Font in IntelliJ and VSCode should be the same. Refer this PR fix: updated icons for knative resources (#131) intellij-knative#132 for reference

[sudhirverma]

@mohitsuman

[mohitsuman]

@sudhirverma KSVC and REV badge sizes are different. The UX doesn't feel good, try to make it a similar size.

[mohitsuman]

@sudhirverma please add the latest image after the fixes in the icon size.

[sudhirverma]

@mohitsuman below image with SVG file

and below image with png file

[lstocchi]

Maybe better with SVG. They don't look very nice but i guess vscode doesn't allow to have bigger icons?? What i really don't like (even in IJ) is the different style between the namespace icon and the rest.

BTW I am not even sure we are doing the right thing about removing the old icons.... Joshua did great from my pov.

[mohitsuman]

Looking at the limitation we have on vscode regarding icon size and how four character string inside a badge does not align with the UI, we are not going to merge these changes. We will be using the same set of icons used by Knative service, eventing and broker as it was approved by knative upstream community.