-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knative Service icon could contain a Knative logo. #196
Comments
+1 for me. |
@nainaz will get this fixed for the next release. |
Wouldn't it be better if we do the same we did for tekton (image below)? From the image above (the Developer view) they do something similar. Using the knative logo for service it doesn't look 100% correct for me. We are saying this resource (service) is represented by this icon. But then a revision could not be represented by the same logo? Or a source? A sink? A broker? |
I went through the k8s community doc and for service, they mention to use the following ion: https://github.com/kubernetes/community/blob/master/icons/svg/resources/unlabeled/svc.svg For reference, here is the slide https://docs.google.com/presentation/d/15h_MHjR2fzXIiGZniUdHok_FP07u1L8MAX5cN1r0j4U/edit#slide=id.g3375c55830_0_25 @lstocchi @sudhirverma I think we should be using the |
That icon is for k8s service which is different from knative service. I'm afraid we are going to do a mix up. |
Yeah Knative Service != Kuberentes Service |
@lstocchi Then having the |
At the moment Knative Service logo in the VScode View is an image of wheels/gear.
Would be nice if the logo for the Service contains actual Knative logo, as it is for example currently done in the OpenShift Developer view:
Or the current namespace icon in Knative Functions Plugin:
The text was updated successfully, but these errors were encountered: