Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative Service icon could contain a Knative logo. #196

Open
zroubalik opened this issue Mar 11, 2022 · 8 comments
Open

Knative Service icon could contain a Knative logo. #196

zroubalik opened this issue Mar 11, 2022 · 8 comments
Milestone

Comments

@zroubalik
Copy link

zroubalik commented Mar 11, 2022

At the moment Knative Service logo in the VScode View is an image of wheels/gear.
logo1

Would be nice if the logo for the Service contains actual Knative logo, as it is for example currently done in the OpenShift Developer view:
ocp

Or the current namespace icon in Knative Functions Plugin:
Snímek obrazovky 2022-03-11 v 16 22 41

@zroubalik
Copy link
Author

CC @rhuss @nainaz

@nainaz
Copy link

nainaz commented Mar 14, 2022

+1 for me.
@mohitsuman Could you take a look please?

@mohitsuman
Copy link
Collaborator

@nainaz will get this fixed for the next release.

@lstocchi
Copy link
Contributor

lstocchi commented Mar 21, 2022

Wouldn't it be better if we do the same we did for tekton (image below)? From the image above (the Developer view) they do something similar. Using the knative logo for service it doesn't look 100% correct for me. We are saying this resource (service) is represented by this icon. But then a revision could not be represented by the same logo? Or a source? A sink? A broker?

image

@mohitsuman
Copy link
Collaborator

I went through the k8s community doc and for service, they mention to use the following ion: https://github.com/kubernetes/community/blob/master/icons/svg/resources/unlabeled/svc.svg

For reference, here is the slide https://docs.google.com/presentation/d/15h_MHjR2fzXIiGZniUdHok_FP07u1L8MAX5cN1r0j4U/edit#slide=id.g3375c55830_0_25

@lstocchi @sudhirverma I think we should be using the svc icon instead of the kn logo. WDYT ?

@lstocchi
Copy link
Contributor

That icon is for k8s service which is different from knative service. I'm afraid we are going to do a mix up.

@zroubalik
Copy link
Author

Yeah Knative Service != Kuberentes Service

@mohitsuman
Copy link
Collaborator

@lstocchi Then having the KSVC badge works much better.

@mohitsuman mohitsuman modified the milestones: 1.1.0, 1.2.0 Apr 27, 2022
@mohitsuman mohitsuman modified the milestones: 1.2.0, 1.3.0 Jul 20, 2022
@mohitsuman mohitsuman modified the milestones: 1.3.0, 1.4.0 Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants