Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added image checker extension installation tests #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rostalan
Copy link

@rostalan rostalan commented Dec 2, 2024

Added image checker extension installation tests (OCI version) as per #57

@rostalan rostalan requested a review from a team as a code owner December 2, 2024 13:32
@rostalan rostalan changed the title test: added image checker extension verification tests test: added image checker extension installation tests Dec 2, 2024
.gitignore Outdated Show resolved Hide resolved
podman-desktop-extension/package.json Outdated Show resolved Hide resolved
podman-desktop-extension/package.json Outdated Show resolved Hide resolved
podman-desktop-extension/package.json Outdated Show resolved Hide resolved
podman-desktop-extension/tests/src/image-checker.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I have 2 questions:

  • is the switch to module related to this PR ? I have the feeling it should be a separate PR
  • when running the tests, I noticed the report reported a skipped test is this expected ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants