Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Complete container creation #7035

Merged
merged 16 commits into from
Aug 29, 2023
Merged

[ui] Complete container creation #7035

merged 16 commits into from
Aug 29, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 21, 2023 •
edited
Loading

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7019

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 21, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l August 21, 2023 20:21
@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit aca77f3
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64e614780acc910008b85b3f

@feloy feloy mentioned this pull request Aug 21, 2023
Closed
3 tasks
@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

NoCluster Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

Unit Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

Validate Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

Kubernetes Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

Windows Tests (OCP) on commit eea75e3 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

OpenShift Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 471928f finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-7019/ui-complete-container-creation-main branch 2 times, most recently from 4b5e923 to c7c5d0c Compare August 22, 2023 14:19
@feloy feloy force-pushed the feature-7019/ui-complete-container-creation-main branch from c7c5d0c to ff9009f Compare August 22, 2023 14:36
@feloy feloy removed the request for review from kadel August 22, 2023 14:51
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy changed the title [wip] [ui] Complete container creation [ui] Complete container creation Aug 23, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 23, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 28, 2023
@rm3l rm3l added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder labels Aug 28, 2023
@feloy
Copy link
Contributor Author

feloy commented Aug 29, 2023

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e59cfa8 into redhat-developer:main Aug 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More parameters for Container creation
3 participants
@feloy @rm3l @openshift-merge-robot