feat: refactor mac request / release flow #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjannath
reviewed
Dec 13, 2024
cmd/mapt/cmd/aws/hosts/mac.go
Outdated
| @@ -26,7 +26,7 @@ const ( | |||
| archDefault string = "m2" | |||
| osVersion string = "version" | |||
| osVersionDesc string = "macos operating system vestion 11, 12 on x86 and m1/m2; 13, 14 on all archs" | |||
| osDefault string = "14" | |||
| osDefault string = "15" | |||
There was a problem hiding this comment.
seem we are duplicating the constants for default values of arch and os in pkg/provider/aws/action/mac/constants.go
There was a problem hiding this comment.
Ahh yeah..may we need to use those from action on the cmd ...as on actions we need them for sure
This commit move the time consuming effort for having fresh machines on the mac pool from the request action to the release. Now release will manage the root volume replace task and request will create new user credentials and set machine as locked to avoid new workloads to make use of it Signed-off-by: Adrian Riobo <[email protected]>
adrianriobo
force-pushed
the
fix-347b
branch
from
fc60478 to
e72607c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit move the time consuming effort for having fresh machines on the mac pool from the request action to the release. Now release will manage the root volume replace task and request will create new user credentials and set machine as locked to avoid new workloads to make use of it
Fix #347