Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension's vscode engine version * should be compatible with all VS Code editors #1087

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

svor
Copy link
Contributor

@svor svor commented Jul 24, 2024

What does this PR do?

If vsix extension's vscode engine version is *, it should be compatible with all VS Code editor versions

How to test?

1/ Update openvsx-sync.json file by replacing the content with:

[
  {
    "id": "magicstack.MagicPython",
    "version": "1.1.1"
  }
]

It contains magicstack.MagicPython extension which has vscode engine version *
2/ Try to build plugin registry by executing ./build.sh script
3/ Extension should be downloaded and published to the plugin registry

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6803

@svor svor self-assigned this Jul 24, 2024
@svor svor requested review from ibuziuk and SDawley as code owners July 24, 2024 09:22
@svor svor added the made-with-che Changes were made using Che label Jul 24, 2024
@svor svor changed the title extension's vscode engine version * should be compatible with all VS … extension's vscode engine version * should be compatible with all VS Code editors Jul 25, 2024
@svor svor merged commit 99cccaf into devspaces-3-rhel-8 Jul 26, 2024
5 checks passed
@svor svor deleted the sv-fix-download-vsix-script branch July 26, 2024 08:59
@devstudio-release
Copy link
Contributor

Build 3.16 :: pluginregistry_3.x/318: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.16 :: pluginregistry_3.x/318: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7314 triggered

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.16 :: copyIIBsToQuay/2720: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.16 :: sync-to-downstream_3.x/7320: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7304 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link
Contributor

Build 3.16 :: operator-bundle_3.x/3361: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7320 triggered

@devstudio-release
Copy link
Contributor

Build 3.16 :: dsc_3.x/1958: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.16 :: update-digests_3.x/7148: SUCCESS

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.x/3361 triggered

@devstudio-release
Copy link
Contributor

Build 3.16 :: dsc_3.x/1958: SUCCESS

3.16.0-CI

@devstudio-release
Copy link
Contributor

Build 3.16 :: copyIIBsToQuay/2720: SUCCESS

3.16
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.16-15
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.16-v4.16-775933- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.16-775933- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.15-775946- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.15-775946- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.14-775958- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.14-775958- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.13-775945- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.13-775945- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.16-v4.12-775944- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.16-v4.12-775944- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.16-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.16-v4.16-775933- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.16-775933- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.15-775946- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.15-775946- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.14-775958- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.14-775958- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.13-775945- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.13-775945- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.16-v4.12-775944- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.16-v4.12-775944- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.16-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.16-v4.16-775933- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.16-775933- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.15-775946- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.15-775946- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.14-775958- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.14-775958- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.13-775945- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.13-775945- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.16-v4.12-775944- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.16-v4.12-775944- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.16-v4.12-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
made-with-che Changes were made using Che
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants