Add IDEA desktop editor #1067
Closed
Add IDEA desktop editor #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <[email protected]>
svor
reviewed
Apr 10, 2024
Co-authored-by: Valerii Svydenko <[email protected]>
Co-authored-by: Valerii Svydenko <[email protected]>
|
Thanks @svor for reviewing the PR! I addressed all your comments. |
svor
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
I haven't tested it because the image is not published yet, but changes look good to me.
@azatsarynnyy probably we also need to generate devworkspaces with idea-server editor for our getting started samples, for this need to update devfile registry part: https://github.com/redhat-developer/devspaces/blob/devspaces-3-rhel-8/dependencies/che-devfile-registry/build/scripts/generate_devworkspace_templates.sh#L65-L71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jetbrains-idecontainer devspaces-images#560to have the image
registry.redhat.io/devspaces/idea-server-rhel8:3.14publishedWhat does this PR do?
Adds IDEA desktop editor definition.
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5758
Release Notes
Docs PR (if applicable)