chore: remove old staging/devspaces/build-requirements/devspaces-*-pluginregistry folders from spmm-util server once they're outdated #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uginregistry folders from spmm-util server once they're outdated Change-Id: I09305e51700b04197ff4a636e36616320c6d8f70 Signed-off-by: RHDH Build (rhdh-bot) <[email protected]>
nickboldt
changed the title
|
If approved, will likely want to cherrypick this to 3.11 branch and also add the |
SDawley
approved these changes
Jan 8, 2024
|
On the one hand this is a good idea and we should actually start doing it once we have cachito builds running. |
That's why it's a new optional flag, rather than a default behaviour. I got your back. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: remove old staging/devspaces/build-requirements/devspaces-*-pluginregistry folders from spmm-util server once they're outdated
Change-Id: I09305e51700b04197ff4a636e36616320c6d8f70
Signed-off-by: RHDH Build (rhdh-bot) [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
run the script using the new flag
--delete-old-versionscheck if https://download.devel.redhat.com/rcm-guest/staging/devspaces/build-requirements/devspaces-3.7-pluginregistry/ and https://download.devel.redhat.com/rcm-guest/staging/devspaces/build-requirements/devspaces-3.8-pluginregistry/ and https://download.devel.redhat.com/rcm-guest/staging/devspaces/build-requirements/devspaces-3.9-pluginregistry/ are deleted.
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.