Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install runc manually to update to go1.19.12 #1016

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented Oct 11, 2023

What does this PR do?

Trying to fix
CVE-2023-29404
CVE-2023-24540
CVE-2023-24538
CVE-2023-29405
CVE-2023-29402

All of them are related to go binary that comes with runc tool.
After installing runc manually:

bash-4.4$ runc -v
runc version 1.1.4
spec: 1.0.2-dev
go: go1.19.12
libseccomp: 2.5.2

before

bash-4.4$ runc -v
runc version 1.1.4
spec: 1.0.2-dev
go: go1.19.4
libseccomp: 2.5.2

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4585

Release Notes

Docs PR (if applicable)

Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor self-assigned this Oct 11, 2023
@nickboldt nickboldt changed the title chore: install runc manually chore: install runc manually to update to go1.19.12 Oct 12, 2023
@nickboldt
Copy link
Member

nickboldt commented Oct 12, 2023

Tested by launching the UDI 3.10 container:

podman run -it --rm --entrypoint /bin/bash --user root quay.io/devspaces/udi-rhel8:3.10

then:

sh-4.4# runc -v; echo "--"; go version
runc version 1.1.4
spec: 1.0.2-dev
go: go1.19.4
libseccomp: 2.5.2
--
go version go1.19.10 linux/amd64

then install runc:

dnf install golang runc -y

and we still have go 1.19.10 installed, but runc reports go1.19.12:

sh-4.4# runc -v; echo "--"; go version
runc version 1.1.4
spec: 1.0.2-dev
go: go1.19.12
libseccomp: 2.5.2
--
go version go1.19.10 linux/amd64

RPMs installed are:

golang 1.19.10-1.module+el8.8.0+19203+782922b7
runc 1:1.1.4-1.module+el8.8.0+19993+47c8ef84 

@svor
Copy link
Contributor Author

svor commented Oct 12, 2023

@nickboldt current changes are for pluginregistry-rhel8 but not for UDI container.

In pluginregistry we don't have golang and we don't need to install it. All CVE issues are related to /usr/bin/runc

podman run -it --rm --entrypoint /bin/bash --user root quay.io/devspaces/pluginregistry-rhel8:3.10

then

bash-4.4# runc -v; echo "--"; go version
runc version 1.1.4
spec: 1.0.2-dev
go: go1.19.4
libseccomp: 2.5.2
--
bash: go: command not found

after installing runc (I don't want to install golang) dnf install runc -y

bash-4.4# runc -v; echo "--"; go version
runc version 1.1.4
spec: 1.0.2-dev
go: go1.19.12
libseccomp: 2.5.2
--
bash: go: command not found

We see go1.19.12 instead of go1.19.4

@nickboldt
Copy link
Member

We see go1.19.12 instead of go1.19.4

So is that a "built with" declaration then?

@svor
Copy link
Contributor Author

svor commented Oct 13, 2023

So is that a "built with" declaration then?

As I understand, it is

@svor svor merged commit 9e5f3f6 into devspaces-3-rhel-8 Oct 13, 2023
5 checks passed
@svor svor deleted the sv-install-runc branch October 13, 2023 08:17
@devstudio-release
Copy link
Contributor

Build 3.10 :: pluginregistry_3.x/256: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.10 :: pluginregistry_3.x/256: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4937 triggered

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.10 :: copyIIBsToQuay/1997: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.10 :: sync-to-downstream_3.x/4939: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4761 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link
Contributor

Build 3.10 :: operator-bundle_3.x/2148: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4939 triggered

@devstudio-release
Copy link
Contributor

Build 3.10 :: dsc_3.x/1475: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.10 :: update-digests_3.x/4596: SUCCESS

Detected new images: rebuild operator-bundle
* pluginregistry; /DS_CI/operator-bundle_3.x/2148 triggered

@devstudio-release
Copy link
Contributor

Build 3.10 :: dsc_3.x/1475: SUCCESS

3.10.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants