-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: CRW-4828 updating for 3.9 release #1002
Conversation
"3.x": "next" | ||
}, | ||
"THEIA_BUILD_PARAMS": {}, | ||
"OPENSHIFT_VERSIONS_SUPPORTED": { | ||
"3.7": [ | ||
"3.8": [ | ||
"v4.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, technically we don't support 4.14 since it's not live yet (planned for Oct). Can't recall how this field is used ... for the list of IIBs to list in emails and copy to quay, maybe? if so this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Push-latest-container-to-quay, copyIIBsToQuay and email, yeah.
dependencies/job-config.json
Outdated
"v4.13", | ||
"v4.12", | ||
"v4.11", | ||
"v4.10" | ||
], | ||
"3.8": [ | ||
"3.9": [ | ||
"v4.14", | ||
"v4.13", | ||
"v4.12", | ||
"v4.11", | ||
"v4.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop v4.10 since it's EOL in a week. Might have to update the dockerfile to set a new minimum OCP version in the metadata too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've made a note to update the Dockerfiles, but that will probably happen next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some followups
Adding 3.10 as 3.x
Removing 3.7
Onwards towards 3.9
https://issues.redhat.com/browse/CRW-4828