CRW-3487 update to php8.0 #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
force-pushed
the
CRW-3487_php80
branch
from
50829e2 to
9699555
Compare
Change-Id: I358899abc0675c95edcd4bd1ae6500744cd473c6 Signed-off-by: Nick Boldt <[email protected]>
Change-Id: Iec21486b90522cc103b3547e4da2abd59a502da2 Signed-off-by: Nick Boldt <[email protected]>
nickboldt
force-pushed
the
CRW-3487_php80
branch
from
9699555 to
a9c6c5d
Compare
svor
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
The code looks good, but I haven't tested it with our sample.
@nickboldt does our sample work properly with v8.0?
|
haven;t tried. busy trying to unbreak the php xdebug install in https://issues.redhat.com/browse/CRW-3487 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id:...
What does this PR do?
CRW-3487 update to php8.0
Change-Id: I358899abc0675c95edcd4bd1ae6500744cd473c6
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-3487
Note: https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_log
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.