-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add independent submodules #236
chore: add independent submodules #236
Conversation
replace github.com/redhat-developer/app-services-sdk-go/kafkamgmt => ../../kafkamgmt | ||
|
||
replace github.com/redhat-developer/app-services-sdk-go/kafkainstance => ../../kafkainstance | ||
|
||
replace github.com/redhat-developer/app-services-sdk-go/connectormgmt => ../../connectormgmt | ||
|
||
replace github.com/redhat-developer/app-services-sdk-go/registrymgmt => ../../registrymgmt | ||
|
||
replace github.com/redhat-developer/app-services-sdk-go/registryinstance => ../../registryinstance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows us to reference local unreleased changes in the examples.
@@ -0,0 +1,61 @@ | |||
# Releasing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@secondsun @wtrocki I have added an entire section on releasing independent sub modules. Obviously this method has not been executed yet, so we may find some things that do not work when releasing the next time. Worth to have a read.
My dream process
Why
|
Agreed, this is described in the new release process.
Yes this may be better to do than relying on git-chglog.
Can you explain this a bit more? Where does the dev do the tag, on the root? |
Yes.
|
The root module is completely independent from the submodules. Releasing the root will not include any changes from the submodules. If you create a tag for the root module then this means there are no changes in the submodules. |
Yes. It will be a nonfunctional stub used to aggregate all releases if needed. Btw. This is just suggestion/discussion, not strongly related to the PR we have here. |
5b40877
to
f2f183f
Compare
As part of the verification let's create initial releases (despite no new changes are needed) |
Closes #160
This PR introduces sub modules to give us the ability to do independent releases. This is important because the individual clients have their own release schedules and keeping them separate means that SDK consumers will only ever get a change when it is released to stage/production.
Verification
Run the examples:
cd internal go run ./kafkamgmt/kafka_mgmt.go