Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the docker-build-oci-ta pipeline to the configmap #4309

Merged

Conversation

arewm
Copy link
Contributor

@arewm arewm commented Aug 12, 2024

This change had already been made on the UI with
openshift/hac-dev#966, making the change in infra-deployments as well.

References: https://issues.redhat.com/browse/EC-739

@openshift-ci openshift-ci bot requested review from rcerven and tkdchen August 12, 2024 18:39
@arewm arewm force-pushed the add-oci-ta-pipeline branch 2 times, most recently from 8fd9c15 to d1f4c3f Compare August 12, 2024 18:43
This change had already been made on the UI with
openshift/hac-dev#966, making the change in
infra-deployments as well.

References: https://issues.redhat.com/browse/EC-739

Signed-off-by: arewm <[email protected]>
@arewm arewm force-pushed the add-oci-ta-pipeline branch from d1f4c3f to 87615e3 Compare August 12, 2024 18:44
@arewm
Copy link
Contributor Author

arewm commented Aug 12, 2024

I also updated all tags to latest as proposed in #4306

Copy link

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arewm, lcarva, rcerven, simonbaird

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lcarva
Copy link
Member

lcarva commented Aug 12, 2024

/lgtm

@dheerajodha
Copy link
Member

I think the current e2e job failed because it started 10 mins before this fix PR was merged.

/test appstudio-e2e-tests

Copy link

openshift-ci bot commented Aug 12, 2024

@arewm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 87615e3 link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arewm
Copy link
Contributor Author

arewm commented Aug 12, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 8c30e46 into redhat-appstudio:main Aug 12, 2024
6 of 7 checks passed
@arewm arewm mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants