Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootcamp instructions for V2.11 #12

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Update bootcamp instructions for V2.11 #12

wants to merge 17 commits into from

Conversation

arckrish
Copy link
Contributor

No description provided.

Copy link
Member

@strangiato strangiato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor cleanups of the DS_Store files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.DS_Store should not be committed.

I would recommend adding it to the project .git_ignore but also I would recommend setting it in your global git ignore config:

https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just take the .gitignore file from ai-accelerator: https://github.com/redhat-ai-services/ai-accelerator/blob/main/.gitignore

@@ -84,7 +84,7 @@ spec:
+
[TIP]
====
Your Data Science Cluster requires of a dspa, so that you can create pipelines.
Your Data Science Cluster requires a dspa, so that you can create pipelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that you guys didn't modify this, the DSC does not require a DSPA. A project requires a DSPA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the changes. Please review and let me know. Thank you
f13c3bf

Copy link
Contributor Author

@arckrish arckrish Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added .DS_Store to .gitignore - f376aa1

@strangiato
Copy link
Member

@arckrish You will need to manually remove the .DS_Store files.

Something like this should work:

git rm --cached .DS_Store

Copy link

@asheet asheet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants