-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootcamp instructions for V2.11 #12
base: main
Are you sure you want to change the base?
Conversation
Fixed location of 'accident_detect.onnx' in upload command
Fixed docs for intro and working with pipelines
fixed the tip on iterating over client.get_job_status(submission_id)
Fixed rag_llm and some typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few minor cleanups of the DS_Store files.
workshop/.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.DS_Store should not be committed.
I would recommend adding it to the project .git_ignore but also I would recommend setting it in your global git ignore config:
https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also just take the .gitignore file from ai-accelerator: https://github.com/redhat-ai-services/ai-accelerator/blob/main/.gitignore
@@ -84,7 +84,7 @@ spec: | |||
+ | |||
[TIP] | |||
==== | |||
Your Data Science Cluster requires of a dspa, so that you can create pipelines. | |||
Your Data Science Cluster requires a dspa, so that you can create pipelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that you guys didn't modify this, the DSC does not require a DSPA. A project requires a DSPA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed the changes. Please review and let me know. Thank you
f13c3bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added .DS_Store to .gitignore - f376aa1
@arckrish You will need to manually remove the .DS_Store files. Something like this should work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.