Export of internal Abseil changes.

-- 0c2e865b4611eda0b43e64c177ac34540f059be2 by Mark Barolak <[email protected]>: Fix a sample code snippet that assumes `absl::string_view::const_iterator` is `const char*`. This is generally true, however in C++17 builds, absl::string_view is an alias for std::string_view and on MSVC, the std::string_view::const_iterator is an object instead of just a pointer. PiperOrigin-RevId: 233631168 -- 16f472f1b94dabf81632d6845574513546c8026e by Abseil Team <[email protected]>: Updating documentation for custom StrSplit delimiters to reflect the fact that string_view does not have a (string_view, start, len) constructor. PiperOrigin-RevId: 233611745 -- a3192dc5122a9a67e0e4d4d2421b0cdb10612c27 by Eric Fiselier <[email protected]>: Add missing <cassert> include. PiperOrigin-RevId: 233523528 GitOrigin-RevId: 0c2e865b4611eda0b43e64c177ac34540f059be2 Change-Id: Ic12e547da3e9c4fe2e79b880f9426fa3cc0f4866
reddwarf69 · Feb 13, 2019 · 426eaa4 · 426eaa4
1 parent 2901ec3
commit 426eaa4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/absl/container/internal/common.h b/absl/container/internal/common.h
@@ -15,6 +15,7 @@
 #ifndef ABSL_CONTAINER_INTERNAL_CONTAINER_H_
 #define ABSL_CONTAINER_INTERNAL_CONTAINER_H_
 
+#include <cassert>
 #include <type_traits>
 
 #include "absl/meta/type_traits.h"

diff --git a/absl/strings/str_split.h b/absl/strings/str_split.h
@@ -96,9 +96,9 @@ namespace absl {
 //     absl::string_view Find(absl::string_view text, size_t pos) {
 //       auto found = text.find(c_, pos);
 //       if (found == absl::string_view::npos)
-//         return absl::string_view(text.end(), 0);
+//         return text.substr(text.size());
 //
-//       return absl::string_view(text, found, 1);
+//       return text.substr(found, 1);
 //     }
 //   };