Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add "thrift_requester_service_name" metric to thrift context handler #746

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Add "thrift_requester_service_name" metric to thrift context handler #746

wants to merge 2 commits into from

Conversation

wlwanpan
Copy link
Member

@wlwanpan wlwanpan commented Sep 23, 2022 •
edited
Loading

Closes #

💸 TL;DR

Proposing "thrift_requester_service_name" metric to be added to the thrift context handler.

Note: this is a draft PR and if accepted, I'll be sending a format spec change request.

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@wlwanpan wlwanpan changed the title Prom metric add service [WIP] Add "thrift_requester_service_name" metric to thrift context handler Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wlwanpan